Home Original page

refactor(eight_ball): update responses for clarity and humor by electron271 · Pull Request #873 · allthingslinux/tux

Reviewer's Guide

Refactors the eight_ball cog by replacing the single combined responses list with three categorical arrays (yes, no, unsure), populates them with updated, humorous/unfiltered strings to reduce bias, and adjusts the random selection logic to pick first a category then an entry.

File-Level Changes

Change Details Files
Categorized response lists
  • Defined yes_responses, no_responses, unsure_responses
  • Removed the old unified responses list
 tux/cogs/fun/rand.py
Updated and expanded response strings
  • Replaced standard affirmations/denials with more humorous, edgy entries
  • Added profanity-laced and pop-culture references for clarity/humor
 tux/cogs/fun/rand.py
Refactored choice logic
  • Switched from single-list random.choice to nested random.choice(random.choice([...]))
 tux/cogs/fun/rand.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help