Home Original page

Jail/unjail fix by RainzDev · Pull Request #888 · allthingslinux/tux

Reviewer's Guide

This PR fixes issues in the jail and unjail slash commands by removing the explicit atomic=False flag on role operations, enabling default atomic behavior to ensure all role additions/removals succeed as a single operation.

Sequence Diagram: Updated Unjail Process with Atomic Role Restoration

sequenceDiagram
    actor Moderator
    participant Bot
    participant DiscordAPI

    Moderator->>Bot: /unjail [member, reason]
    Bot->>Bot: Identify Jail Role to remove
    Bot->>DiscordAPI: remove_roles(member, JailRole, reason)
    DiscordAPI-->>Bot: Jail Role removed
    Bot->>Bot: Identify member's roles to restore (roles_to_restore)
    Bot->>DiscordAPI: add_roles(member, roles_to_restore, reason) [Atomic]
    DiscordAPI-->>Bot: Roles restored (all or none)
    Bot-->>Moderator: Confirmation of unjailing
Loading

File-Level Changes

Change Details Files
Enable atomic role removal in jail command
  • Removed atomic=False argument from the member.remove_roles call
 tux/cogs/moderation/jail.py
Enable atomic role addition in unjail command
  • Removed atomic=False argument from the member.add_roles call
 tux/cogs/moderation/unjail.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help