fix(compiler-cli): track poisoned scopes with a flag (#39967)

fix(compiler-cli): track poisoned scopes with a flag (#39967) · angular/angular@178cc51

@@ -70,6 +70,8 @@ export interface ComponentAnalysisData {

7070 * require an Angular factory definition at runtime.7171 */7272viewProvidersRequiringFactory: Set<Reference<ClassDeclaration>>|null;73+74+isPoisoned: boolean;7375}74767577export type ComponentResolutionData = Pick<R3ComponentMetadata, ComponentMetadataResolvedFields>;

@@ -86,7 +88,7 @@ export class ComponentDecoratorHandler implements

8688private templateMapping: TemplateMapping, private isCore: boolean,8789private resourceLoader: ResourceLoader, private rootDirs: ReadonlyArray<string>,8890private defaultPreserveWhitespaces: boolean, private i18nUseExternalIds: boolean,89-private enableI18nLegacyMessageIdFormat: boolean,91+private enableI18nLegacyMessageIdFormat: boolean, private usePoisonedData: boolean,9092private i18nNormalizeLineEndingsInICUs: boolean|undefined,9193private moduleResolver: ModuleResolver, private cycleAnalyzer: CycleAnalyzer,9294private refEmitter: ReferenceEmitter, private defaultImportRecorder: DefaultImportRecorder,

@@ -359,6 +361,7 @@ export class ComponentDecoratorHandler implements

359361 template,360362 providersRequiringFactory,361363 viewProvidersRequiringFactory,364+isPoisoned: diagnostics !== undefined && diagnostics.length > 0,362365},363366 diagnostics,364367};

@@ -383,6 +386,7 @@ export class ComponentDecoratorHandler implements

383386isComponent: true,384387baseClass: analysis.baseClass,385388 ...analysis.typeCheckMeta,389+isPoisoned: analysis.isPoisoned,386390});387391388392if (!analysis.template.isInline) {

@@ -394,15 +398,19 @@ export class ComponentDecoratorHandler implements

394398395399index(396400context: IndexingContext, node: ClassDeclaration, analysis: Readonly<ComponentAnalysisData>) {401+if (analysis.isPoisoned && !this.usePoisonedData) {402+return null;403+}397404const scope = this.scopeReader.getScopeForComponent(node);398405const selector = analysis.meta.selector;399406const matcher = new SelectorMatcher<DirectiveMeta>();400-if (scope === 'error') {401-// Don't bother indexing components which had erroneous scopes.402-return null;403-}404-405407if (scope !== null) {408+if ((scope.compilation.isPoisoned || scope.exported.isPoisoned) && !this.usePoisonedData) {409+// Don't bother indexing components which had erroneous scopes, unless specifically410+// requested.411+return null;412+}413+406414for (const directive of scope.compilation.directives) {407415if (directive.selector !== null) {408416matcher.addSelectables(CssSelector.parse(directive.selector), directive);

@@ -429,9 +437,13 @@ export class ComponentDecoratorHandler implements

429437return;430438}431439440+if (meta.isPoisoned && !this.usePoisonedData) {441+return;442+}443+432444const scope = this.typeCheckScopes.getTypeCheckScope(node);433-if (scope === 'error') {434-// Don't type-check components that had errors in their scopes.445+if (scope.isPoisoned && !this.usePoisonedData) {446+// Don't type-check components that had errors in their scopes, unless requested.435447return;436448}437449

@@ -443,6 +455,10 @@ export class ComponentDecoratorHandler implements

443455444456resolve(node: ClassDeclaration, analysis: Readonly<ComponentAnalysisData>):445457ResolveResult<ComponentResolutionData> {458+if (analysis.isPoisoned && !this.usePoisonedData) {459+return {};460+}461+446462const context = node.getSourceFile();447463// Check whether this component was registered with an NgModule. If so, it should be compiled448464// under that module's compilation scope.

@@ -455,7 +471,7 @@ export class ComponentDecoratorHandler implements

455471wrapDirectivesAndPipesInClosure: false,456472};457473458-if (scope !== null && scope !== 'error') {474+if (scope !== null && (!scope.compilation.isPoisoned || this.usePoisonedData)) {459475// Replace the empty components and directives from the analyze() step with a fully expanded460476// scope. This is possible now because during resolve() the whole compilation unit has been461477// fully analyzed.