[BEAM-14433] Improve Go split error message. by lostluck · Pull Request #17575 · apache/beam

This change improves the error message when a channel split fails with the full split state and avoids a performance issue WRT listing all the split indices in the error message as the string conversion is expensive.

Instead of listing all splits, since we've already sorted them all, we simply list the count and the first and last split indices. This gives us enough information to see what happened to cause the failure, which the current message lacks. The length and first and last would let a debugger determine if the range was complete or not.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.