[BEAM-14470] Use lifecycle method names directly. by lostluck · Pull Request #17790 · apache/beam
Use lifecycle method names directly, rather than excluding all exported methods on DoFns.
Breaks certain usecases with extreme number (10+) of emitter parameters, when the method doesn't have a generic representation. The static code generator works in those cases, but it isn't recommended.
The ideal work around would be to have a tagged API instead of the positional one, but that's significantly more work.
Using lifecycle names directly neutered the previous verification check anyway, so we've opted to remove that entirely. Additional tests were also added to ensure the fallthrough behavior occurs.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- Choose reviewer(s) and mention them in a comment (
R: @username). - Format the pull request title like
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - Update
CHANGES.mdwith noteworthy changes. - If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.