[Fixes #18679] Ensure that usage of metrics on a template job reports an error by lukecwik · Pull Request #18905 · apache/beam
Note that the usage of DataflowMetrics with a template job was throwing an NPE due to the direct access of the jobId parameter.
I also ensured that getting transform step names was accessed via a method instead of reaching into the object directly.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- Choose reviewer(s) and mention them in a comment (
R: @username). - Add a link to the appropriate issue in your description, if applicable. This will automatically link the pull request to the issue.
- Update
CHANGES.mdwith noteworthy changes. - If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.