fix minor unreachable code caused by log.Fatal by Abirdcfly · Pull Request #22618 · apache/beam
Fatalf is equivalent to Printf() followed by a call to os.Exit(1).
see https://go.dev/play/p/iw2MCkHArJZ for example:
package main import "log" func main() { log.Println("Println will print and not exit") log.Fatalf("Fatalf will print and exit") log.Println("this line cant reach") } /* output: 2009/11/10 23:00:00 Println will print and not exit 2009/11/10 23:00:00 Fatalf will print and exit Program exited. */
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- Choose reviewer(s) and mention them in a comment (
R: @username). - Mention the appropriate issue in your description (for example:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead. - Update
CHANGES.mdwith noteworthy changes. - If this contribution is large, please file an Apache Individual Contributor License Agreement.
See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.
R: @lostluck
R: @jrmccluskey
(just found that you have recently reviewed the go code)