feat(#116): hidden by zz-zhi54 · Pull Request #457 · apache/fesod
Pull Request Overview
This PR implements a feature to hide Excel columns using the @HeadStyle(hidden = BooleanEnum.TRUE) annotation, addressing issue #116.
- Adds a new
HiddenShellWriteHandlerto process column hiding based on annotation configuration - Integrates the handler into the existing write handler chain
- Adds documentation for the existing
hidden()method inHeadStyleannotation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AbstractWriteHolder.java | Registers the new HiddenShellWriteHandler in the write handler chain |
| HiddenShellWriteHandler.java | New handler that processes @HeadStyle(hidden=true) annotations to hide Excel columns |
| HeadStyle.java | Adds documentation referencing the new handler implementation |
| HiddenShellTest.java | Test case demonstrating the column hiding functionality |
Comments suppressed due to low confidence (2)
fastexcel/src/main/java/cn/idev/excel/write/handler/impl/HiddenShellWriteHandler.java:18
- The class name 'HiddenShellWriteHandler' is misleading since it hides columns, not shells. Consider renaming to 'HiddenColumnWriteHandler' for clarity.
public class HiddenShellWriteHandler implements SheetWriteHandler {
fastexcel-test/src/test/java/cn/idev/excel/test/fix/issue116/HiddenShellTest.java:15
- The test class name 'HiddenShellTest' should be 'HiddenColumnTest' to accurately reflect that it tests column hiding functionality.
public class HiddenShellTest {