fix release ci by coderzc · Pull Request #1770 · apache/hugegraph

fix release ci by coderzc · Pull Request #1770 · apache/hugegraph

		mvn clean package -DskipTests
		mv "$(find hugegraph-*.tar.gz \| head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

		- name: Rename file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need to split into 2 stages? can put "mvn clean package -DskipTests" into "Rename file" stage?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of the "Rename file" operation is not unessential

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

		mv "$(find hugegraph-*.tar.gz \| head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

		- name: Rename file
		if: contains(env.TAG_NAME, "-")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed error mv: '***-0.12.0.tar.gz' and '***-0.12.0.tar.gz' are the same file

		if: contains(env.TAG_NAME, "-")
		run: mv "$(find hugegraph-*.tar.gz \| head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

		- uses: xresloader/upload-to-github-release@master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add name "Upload to GitHub"

		mvn clean package -DskipTests
		mv "$(find hugegraph-*.tar.gz \| head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

		- name: Rename file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

		mv "$(find hugegraph-*.tar.gz \| head -1)" hugegraph-${TAG_NAME/#v/}.tar.gz

		- name: Rename file
		if: contains(env.TAG_NAME, "-")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only need to rename when TAG_NAME is like 0.12.0-b2?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

CLA Assistant Lite bot Good! All Contributors have signed the CLA.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could sign new CLA again

I have read the CLA Document and I hereby sign the CLA