Bump grpc version to support build on apple m1 by hezhangjian · Pull Request #1914 · apache/hugegraph
Thanks for your contribution, is there anyway to test the diff (or ensure it's fine on m1)?
@seagle-yuan any suggestion or could we test it?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one tiny comment
| @@ -60,13 +60,19 @@ public final int getNumber() { | |||
| } | |||
|
|
|||
| /** | |||
| * @param value The numeric wire value of the corresponding enum entry. | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we not update RaftRequests.java file?
@javeme I think we should update the RaftRequests.java. It's generated by grpc. We should keep it consistent.
We'd better not commit this file to the repository, but that's another optimization point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters