GH-1668: Add catch-all for group filter by cstamas · Pull Request #1694

GH-1668: Add catch-all for group filter by cstamas · Pull Request #1694 · apache/maven-resolver

		assertFalse(groupTree.acceptedGroupId("org.apache.maven.bar.aaa"));

		assertTrue(groupTree.acceptedGroupId("org.apache.baz"));
		assertFalse(groupTree.acceptedGroupId("org.apache.baz.aaa"));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a problem here.

Applicable rules:

1st: "allow org.apache.baz ONLY"
2nd: default to ALLOW

So why is then org.apache.baz.aaa rejected?

Seems the mod = causes some issues....

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, is not the =... simply, the logic to reject was coded in tree. What is needed is "fallback to root allow" and a change to make root always have allow set (before it was allow != null && allow, which is false if allow was null), now root allow is explicitly set to false or flipped if * present.