fix: Fix non-ASCII character corruption in `FileSystemStorageClient` on systems without UTF-8 default encoding by Mantisus · Pull Request #1580 · apify/crawlee-python
| await Dataset.open(name=name, storage_client=storage_client) | ||
|
|
||
|
|
||
| async def test_record_with_noascii_chars(dataset: Dataset) -> None: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is in file system storage only. We can either move this check to file system storage client tests or test with all possible storage clients - your call.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the tests for all possible storage clients. 🙂
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, the dataset fixture uses the parametrized storage client fixture. Makes sense.
| await Dataset.open(name=name, storage_client=storage_client) | ||
|
|
||
|
|
||
| async def test_record_with_noascii_chars(dataset: Dataset) -> None: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, the dataset fixture uses the parametrized storage client fixture. Makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters