fix: Prevent race condition in concurrent storage creation by Mantisus · Pull Request #1626 · apify/crawlee-python
Codecov Report
❌ Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.46%. Comparing base (30f8e15) to head (5183f2c).
⚠️ Report is 7 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/crawlee/storages/_storage_instance_manager.py | 93.02% | 3 Missing ⚠️ |
Additional details and impacted files
@@ Coverage Diff @@ ## master #1626 +/- ## ========================================== - Coverage 92.48% 92.46% -0.02% ========================================== Files 157 157 Lines 10421 10437 +16 ========================================== + Hits 9638 9651 +13 - Misses 783 786 +3
| Flag | Coverage Δ | |
|---|---|---|
| unit | 92.46% <93.02%> (-0.02%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters