Home Original page

bug: minor log fix by souravjain540 · Pull Request #341 · apify/crawlee-python

Conversation

@souravjain540

Description

wrong command in the log: 'pip install crawlee[playwright]', it should be "pip install 'crawlee[playwright]'"

Issues

  • N/A

Testing

  • N/A

Checklist

  • Changes are described in the CHANGELOG.md
  • CI passed

@vdusek

  • I understand the reasoning behind using single quotes around the package name with the extra, as it helps with shell compatibility when dealing with brackets.
  • The backticks... Since this is just a log line without any formatting, I'm unsure whether using backticks (`) isn't just less readable.

What do you think @janbuchar?

janbuchar

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdusek I think the backticks are fine. We may want to use colors instead at some point, but there's no need to stall such a minor PR because of that.

Co-authored-by: Jan Buchar <jan.buchar@apify.com>

vdusek

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@B4nan

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

@janbuchar

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

I mean, we can update the log generator to put bug: in the same bucket as fix:

@souravjain540

hmm, we need the PR title check here. bug: prefix for any PR makes no sense unless you planned to introduce a new bug with the PR :D

Hehehe, sorry!

@B4nan

I mean, we can update the log generator to put bug: in the same bucket as fix:

or we can actually follow the specs and not use random prefixes like bug: :D

@B4nan