refactor!: Rename PwPreNavContext to PwPreNavCrawlingContext by vdusek · Pull Request #827 · apify/crawlee-python
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it should be consistently named. I am split on using abbreviations, I like to make the name shorter, but on the other hand "Explicit is better than implicit".
If the developer will have to constantly look what some abbreviation means, then it is bad. If on the other hand it is natural and people understand it out of the box, then I think it is OK.
PwPreNavCC? Why not if the docstring starts as """PlaywrightPreNavigationCrawlingContext is ...." Even though I would maybe keep at least one full key word in the name to roughly recognize the type on the first glance. For example: PwPreNavCContext