The addition to #477 by TikhomirovSergey · Pull Request #480

The addition to #477 by TikhomirovSergey · Pull Request #480 · appium/java-client

Change list

the enum io.appium.java_client.android.ConfiguratorParameters was removed
new elements were added to the io.appium.java_client.android.Settings
refactoring of the io.appium.java_client.HasSettings.

Types of changes

What types of changes are you proposing/introducing to Java client?

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

This change was made according to the conversation #477 (see the end)

- the enum `io.appium.java_client.android.ConfiguratorParameters` was removed
- new elements were added to the `io.appium.java_client.android.Settings`
- refactoring of the `io.appium.java_client.HasSettings`.

		@@ -76,8 +76,7 @@ default void ignoreUnimportantViews(Boolean compress) {
		* @param timeout in milliseconds, 0 would reset to its default value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

negative value would reset, not 0, for all configurator settings.Because in some circumstances, 0 would be used to disable timeouts on purpose. see here

		@Test public void configuratorTest() {
		driver.configuratorSetActionAcknowledgmentTimeout(5);
		assertJSONElementContains("setActionAcknowledgmentTimeout", 5);
		assertJSONElementContains(Setting.WAIT_ACTION_ACKNOWLEDGMENT_TIMEOUT, 5);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timeout value is in milliseconds. use 500 or more could be more understandable.