Change list

Feature: Add support for "driver.status()" - #1137

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• [x ] No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• [x ] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

• Implemented driver status check as requested in Feature: Add support for "driver.status()" #1137 which returns AppiumServerStatus object containing a field for returning the version of running appium server.
• Added a sample test to validate if the version is of form "x.y"

The tests are failing even when no changes are made in the code.
Refer #1155 which has a change in Readme text only.

This failure shouldn't be related to the code implemented here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now. Can you keep styling as per the style guides we use?

@SrinivasanTarget Current changes have been done through standard auto-formatting in Java. Any reference to style guides doc for my understanding so that I can update it accordingly and be proactive in my future commits?

@anilkrverma Can you rebase your branch with the latest master once as a final nit. CI should be green after that.

Hurray, CI is green now. :)

This does not look like a rebase

…instead of AppiumServerStatus class object.

- Deleted AppiumServerStatus class as it is no longer needed.

- Empty line should be followed by <p> tag on the next line.	234
- First sentence of Javadoc is missing an ending period.	234

Ran ./gradlew clean checkstyleMain, BUILD is SUCCESSFUL now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments. Looks good👍