Home Original page

chore: Add more UiAutomator2 options by mykola-mokhnach · Pull Request #1545 · appium/java-client

@mykola-mokhnach

Change list

Continuing to add UiAutomator2 options.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach

SrinivasanTarget

@mykola-mokhnach

valfirst

public interface SupportsIsHeadlessOption<T extends BaseOptions<T>> extends
Capabilities, CanSetCapability<T> {
String IS_HEADLESS_OPTION = "isHeadless";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to add a method:

default T headless() {
    return setIsHeadless(true);
}

?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

valfirst

public interface SupportsGpsEnabledOption<T extends BaseOptions<T>> extends
Capabilities, CanSetCapability<T> {
String GPS_ENABLED_OPTION = "gpsEnabled";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to add a method:

default T gpsEnabled() {
    return setGpsEnabled(true);
}

?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@mykola-mokhnach