refactor: change prefix to `AppiumBy` in locator `toString` implement… by valfirst · Pull Request #1559 · appium/java-client

refactor: change prefix to `AppiumBy` in locator `toString` implement… by valfirst · Pull Request #1559 · appium/java-client

Conversation

Change list

Adds lost changes addressing the review comment: #1538 (comment)

Types of changes

What types of changes are you proposing/introducing to Java client?

No changes in production code.
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Change the prefix from By. to AppiumBy. in locator toString implementation.

		* @return an instance of {@link MobileBy.ByWindowsAutomation}
		*/
		@Deprecated
		public static By windowsAutomation(final String windowsAutomation) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is needed to keep backward compatibility: ByWindowsAutomation#toString should return the result in old format

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure if we need this locator type at all. I did not hear about some special Windows location strategies that are different from these that Selenium supports.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the windows driver is not in active development for an year now and they are still in JWP and not in W3C.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in windows test automation at all, so should I remove this locator at all? or should I just remove this piece of deprecations?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we remove it from AppiumBy interface and add a comment about that to the legacy one. Although I'd like to confirm that with our Windows expert @akinsolb first (e.g. does dotnet client expose such locator and if yes then for which purpose it is used)?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE #462 It's amazing that java, ruby and python have reference to that -windows uiautomation and the server doesn't. I'll mark it as obsolete for the next release

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, i see. will mark it as deprecated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.