fix: Override getScreenshotAs to support the legacy base64 encoding by mykola-mokhnach · Pull Request #1787 · appium/java-client

@mykola-mokhnach

Change list

Addresses SeleniumHQ/selenium#11168

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach

SrinivasanTarget

@mykola-mokhnach

valfirst

@mykola-mokhnach

@mykola-mokhnach

valfirst

@krishtoautomate

Possible to create maven build of appium java client with this patch?

@sergey-lysenko

This only fixed fullscreen screentshots, while calling method of WebElement falls back to default implementation and fails the test.

I guess the only option now (untill overriding is the only option) is to create a routine in tests which will make a full screenshot, then crop needed part based on WebElement's dimentions.

@mykola-mokhnach

This only fixed fullscreen screentshots, while calling method of WebElement falls back to default implementation and fails the test.

I guess the only option now (untill overriding is the only option) is to create a routine in tests which will make a full screenshot, then crop needed part based on WebElement's dimentions.

This patch is ugly and it anyway would make sense to apply it on Selenium side instead. Or simply use the newest version of an appium driver, where it generates a compatible base64-encoding.