fix: Update hashing and iteration logic of page object items by mykola-mokhnach · Pull Request #2067 · appium/java-client
Change list
Adresses #2066
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
| includeTestsMatching 'io.appium.java_client.android.OpenNotificationsTest' | ||
| includeTestsMatching '*.AndroidAppStringsTest' | ||
| includeTestsMatching '*.pagefactory_tests.widget.tests.android.*' | ||
| includeTestsMatching '*.pagefactory_tests.widget.tests.AndroidPageObjectTest' |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it removed intentionally?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. The current pattern does not match anything. I've fixed it, but these tests still fail because of the CI slowness (I've verified them locally though). Maybe someone would find some time to make them work in the slow CI env 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters