fix: Fix compatibility with latest Selenium snapshots by valfirst · Pull Request #2249 · appium/java-client
Change list
Fix compatibility with latest Selenium snapshots.
Types of changes
What types of changes are you proposing/introducing to Java client?
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
Recently Selenium team has introduced an update for Appium client adding ability to get additionalCommands in HttpCommandExecutor: SeleniumHQ/selenium@59aa1a0.
But since new method is public and the same Appium method in AppiumCommandExecutor.java is protected, this collision introduces an error at the build stage:
/Users/runner/work/java-client/java-client/src/main/java/io/appium/java_client/remote/AppiumCommandExecutor.java:136: error: getAdditionalCommands() in AppiumCommandExecutor cannot override getAdditionalCommands() in HttpCommandExecutor
protected Map<String, CommandInfo> getAdditionalCommands() {
> Task :compileJava FAILED
^