Home Original page

feat: Implement HasBiDi interface support in AppiumDriver by mykola-mokhnach · Pull Request #2250 · appium/java-client

Conversation

@mykola-mokhnach

Change list

This is the first PR in series where I would like to implement BiDi protocol support with Java client.
The Appium server and drivers only support some parts of the spec, but something is better than nothing (also not everything in the spec makes sense for our context). In time I expect the variety of events and commands to grow bigger.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

mykola-mokhnach

setSessionId(sessionAddress.getId());
}

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these methods were just moved to the end of the class definitions, no changes made to them

KazuCocoa

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

valfirst