Home Original page

#471 FIX by TikhomirovSergey · Pull Request #538 · appium/java-client

@TikhomirovSergey

Change list

  • WindowsDriver was designed
  • WindowsElement was designed
  • WindowsKeyCode was added
  • Page object tools were updated:
    • WindowsFindBy was added
    • AppiumFieldDecorator and supporting tools were actualized

Additional change:

  • All constructors declared by AppiumDriver are public now.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

#471 FIX
#530 FIX

- WindowsDriver was designed
- WindowsElement was designed
- WindowsKeyCode was added
- Page object tools were updated:
  - WindowsFindBy was added
  - AppiumFieldDecorator and supporting tools were actualized

  Additional change:
  All constructors declared by AppiumDriver are public now.

@TikhomirovSergey

@TikhomirovSergey

SrinivasanTarget

String contextName =
String.valueOf(execute(DriverCommand.GET_CURRENT_CONTEXT_HANDLE).getValue());
if (contextName.equals("null")) {
if ("null".equalsIgnoreCase(String.valueOf(contextName))) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant this be done using java Optional class?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contextName is already a string right then why are we using valueof() again?

SrinivasanTarget

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just few questions but LGTM 👍

yodurr

ANDROID_UI_AUTOMATOR(MobilePlatform.ANDROID.toLowerCase(), AndroidElement.class),
IOS_UI_AUTOMATION(MobilePlatform.IOS.toLowerCase(), IOSElement.class);
IOS_UI_AUTOMATION(MobilePlatform.IOS.toLowerCase(), IOSElement.class),
WINDOwS(MobilePlatform.WINDOWS, WindowsElement.class);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lowercase w?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Maybe it is excessive :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I mean why is it "WINDOwS" on line 40?  Shouldn't it be all caps?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will improve that :)

yodurr
if (iOSFindByArray != null && iOSFindByArray.length == 1) {
return createBy(new Annotation[] {iOSFindByArray[0]}, HowToUseSelectors.USE_ONE);
return createBy(new Annotation[] {iOSFindByArray[0]}, HowToUseSelectors.USE_ONE);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should undo the extra space

@yodurr

This work is great to see, thank you Sergey!

@TikhomirovSergey

@TikhomirovSergey