Home Original page

Addition to the #579 by TikhomirovSergey · Pull Request #585 · appium/java-client

Conversation

@TikhomirovSergey

Change list

The chaining of the activity parameter setting.

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
The chaining of the activity parameter setting.

@TikhomirovSergey

mykola-mokhnach

driver.startActivity(activity);
return true;
}).test(driver));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line here

@SrinivasanTarget

mykola-mokhnach

activity.setIntentFlags("0x4000000");
activity.setOptionalIntentArguments("-d \"TestIntent\" -t \"text/plain\"");
driver.startActivity(activity);
return true;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the whole construction with assertTrue and return true really necessary?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach
Yes. It is for codecy checkings. It requires assertions. Also I have an opinion that assertions inside tests methods is the good style.

@TikhomirovSergey

@email2vimalraj

@TikhomirovSergey : Good idea.

Kindly update the The-starting-of-an-Android-app.md file and the javadoc on the StartsActivity.java interface.

Labels