added get_current_package session by saikrishna321 · Pull Request #657 · appium/java-client
Conversation
Change list
Appium 1.6.6 beta has a new endpoint for getting the currently running package during an Android test.
See appium/appium-base-driver@190a896
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
|
||
| } | ||
|
|
||
| @Test public void getCurrentPackage() { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to getCurrentPackageTest() ?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| CommandExecutionHelper.execute(this, toggleLocationServicesCommand()); | ||
| } | ||
|
|
||
| public String getCurrentPackage() { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to move this method to the io.appium.java_client.android.StartsActivity interface and to make it default.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters