Update touch ID enroll method by mykola-mokhnach · Pull Request #695 · appium/java-client

SrinivasanTarget

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

* This method is deprecated. Please use {@link #toggleTouchIDEnrollment(boolean)} instead
*/
@Deprecated
default void toggleTouchIDEnrollment() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach We haven't released a version after this implementation. Can we remove this or Do you still wanted it to be marked deprecated?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking it as deprecated is safer. We can remove as soon as beta is released (what we, actually, always do)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm ok