Home Original page

#714 FIX by TikhomirovSergey · Pull Request #717 · appium/java-client

Conversation

@TikhomirovSergey

Change list

  • Update to Selenium 3.5.3
  • phantomJSdriver and htmlunit-drive were excluded
  • eclipse compiler was updated to 4.6.1
  • also AppiumElementLocator was improved

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Dependencies of the html unit driver
https://mvnrepository.com/artifact/org.seleniumhq.selenium/htmlunit-driver/2.27

Dependencies of the phantom js driver
https://mvnrepository.com/artifact/com.codeborne/phantomjsdriver/1.4.3

Also something weird was foaund in AppiumElementLocator. I wonder why we couldn't find it before.

- Update to Selenium 3.5.3
- phantomJSdriver and htmlunit-drive were excluded
- eclipse compiler was updated to 4.6.1

mykola-mokhnach

import static io.appium.java_client.pagefactory.ThrowableUtil.isStaleElementReferenceException;


import com.google.common.base.Function;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see this import in several other sources - are they all expected?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach No
Except the AppiumFunction class. I improved sourses at my last commit

mykola-mokhnach

}

ext.seleniumVersion = '[3.5.2,3.5.2]'
ext.seleniumVersion = '[3.5.3,3.5.3]'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the point to set a range, which includes only one item? Isn't it simply equal to '3.5.3'?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach The purpose is to make a valid pom.xml file. The version like 3.5+ is malformed for maven.

mykola-mokhnach

@mykola-mokhnach

I was also thinking about enforcing the version of guava library, since our module cannot work if it is older than 20

@SrinivasanTarget

SrinivasanTarget

@TikhomirovSergey

mykola-mokhnach

}

return result;
if (result.size() == 0) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return result.isEmpty() ? null : result;

@TikhomirovSergey

@SrinivasanTarget

I think it is not necessary to force the com.google.guava:guava:23.0 because Selenium already depends on this version.

Ok

Labels