Add pushFile support to IOSDriver by mykola-mokhnach · Pull Request #721 · appium/java-client
Conversation
Change list
The PR adds support of pushFile endpoint to IOSDriver. For now it is only possible to upload media file to Simulator.
Types of changes
- No changes in production code.
- Bugfix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
Details
Addresses #720
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mykola-mokhnach
It looks ok. But I have a question. What the difference between the PushesFiles in the android package and the PushesFiles in the ios package? Maybe it has more sense to move interface to the java_client
For iOS the documentation differs, wince the call works for Simulator only, but the body is the same. Frankly speaking, I don't see a need to extract these methods into a common lib - they anyway contain 1 to 3 lines of code. Even the documentation takes more space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
2 participants