Add endpoints for screen recording API for iOS and Android by mykola-mokhnach · Pull Request #814 · appium/java-client

Conversation

@mykola-mokhnach

Change list

Add endpoints for screen recording API for iOS and Android

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

appium/appium-android-driver#303
appium/appium-xcuitest-driver#609

TikhomirovSergey

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach There is the conflict. Could you resolve it?
Will try it ASAP .

@mykola-mokhnach

SrinivasanTarget

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding some tests will be good still.

@mykola-mokhnach

@SrinivasanTarget I would be happy to add tests, but currently the client interaction with Appium beta is broken, so I cannot even init a session properly. See appium/appium#10055 for more details.

@SrinivasanTarget

@mykola-mokhnach

SrinivasanTarget

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TikhomirovSergey