Home Original page

Support syslog broadcast with iOS by mykola-mokhnach · Pull Request #871 · appium/java-client

Conversation

@mykola-mokhnach

Change list

Based on appium/appium-xcuitest-driver#653

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

SrinivasanTarget

import java.util.Collections;
import java.util.function.Consumer;

public interface ListensToSyslogMessages extends ExecutesMethod {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mykola-mokhnach Its same as Logcat Listerners which you have added some time back. Any reason why both are separate interfaces apart from naming convention of Logcat for Android and Syslog for iOS? Do you forcast anything in future where we will have it in android and not in iOS or viceviz.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I think something may change there, so we keep it separate for both platforms. Would you prefer to combine the interfaces?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its fine

@TikhomirovSergey

SrinivasanTarget