Home Original page

#995 add android viewtag for espresso driver by saikrishna321 · Pull Request #996 · appium/java-client

Conversation

@saikrishna321

Change list

Related : appium/appium-espresso-driver#189

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

SrinivasanTarget

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AndroidDriver needs to implement FindsByAndroidViewTag

return super.findElement(context);
}

throw formIllegalArgumentException(contextClass, FindsByAccessibilityId.class,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FindsByAndroidViewTag

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

SrinivasanTarget

/**
* This locator strategy is available in Espresso Driver mode.
* @since Appium 1.8.2 beta
* @param tag is an an view tag string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

mykola-mokhnach

import io.appium.java_client.FindsByAndroidUIAutomator;
import io.appium.java_client.HasOnScreenKeyboard;
import io.appium.java_client.LocksDevice;
import io.appium.java_client.*;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember the linter does like star imports

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

mykola-mokhnach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except of linter issues

SrinivasanTarget

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Codacy and travis warnings needs to be fixed though.