Support exporting current container to image by JaewonHur · Pull Request #1172 · apple/container
Conversation
This PR adds a command to export container to image (#1019).
Type of Change
- Bug fix
- New feature
- Breaking change
- Documentation update
Motivation and Context
Users can export their container to image.
Testing
- Tested locally
- Added/updated tests
- Added/updated docs
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Adding a basic CLI integration test would be good as well
@jglogan This PR has minimal test writing a file before exporting a container and checking it remains correct in the exported image.
Do you have any edge cases to be checked ? e.g., volume mount should not be preserved..?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters