fix(common.yml): globalize CURRENT_SDK, improve shell safety and imp… by Thedarkmatter10 · Pull Request #178 · apple/container

🔧 Improvements Summary

This PR introduces three improvements focused on safety, maintainability, and readability of the GitHub Actions workflow.


1. Define Global Environment Variable

Before:

Environment variable CURRENT_SDK was defined repeatedly in multiple steps.

After:

Declared in gloabally one time.

Why This Matters:

  • Eliminates duplication across steps.
  • Makes it easier to update or remove the variable in the future.
  • Still allows per-step override when necessary.

2. Fix Unsafe Shell Conditional on inputs.release

3. Removed EXCLUSION AND TODO comment.

Affected Steps:

check Formatting

make proto

Improvements:

Now that the repositories are public, we no longer need to exclude files like Package.swift and Package.resolved from formatting and proto checks.

  • Removed EXCLUDES logic
  • Removed related TODO comments
  • Updated git diff checks to include all files

@wlan0 @katiewasnothere