Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy by rujhan-arora-astronomer · Pull Request #1752 · astronomer/astro-cli

Conversation

@rujhan-arora-astronomer

Description

Introduction of sha_as_tag=True config in astro cli which will be used during Astro deploy.

  1. Option to set sha_as_tag true in config.
  2. During astro deploy, using the sha digest when we make a call to the updateDeploymentImage endpoint in Houston, instead of the runtime version tag.

🎟 Issue(s)

Related https://github.com/astronomer/issues/issues/6836

🧪 Functional Testing

Testing locally and on staging cluster too.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

neel-astro

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to squash, but looks ok otherwise

neel-astro

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left final set of comments, but LGTM otherwise

neel-astro

2 participants

@rujhan-arora-astronomer @neel-astro