Removes dead code for conflict-test by schnie · Pull Request #1797 · astronomer/astro-cli

Description

This PR removes some seemingly dead code. This conflictTest variable will always evaluate to false, so we're removing all the code that would run if we branched on this value being true. Seems like it used to be a flag that we've removed along the way. Not sure how else this code would ever run.

Update: I found this digging through the history. Looks like we intentionally removed the functionality, but didn't remove the dead code. @kushalmalani even suggested it here.

🎟 Issue(s)

No issue, just noticed while looking at other things.

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation