Block unsupported Airflow 3 commands by jeremybeard · Pull Request #1822 · astronomer/astro-cli
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I haven't tried it, but what if no runtime version is specified in the command? will that cause the command to default to AF 3 version and then get blocked here on day 0?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, the user will need to specify the runtime version for the command to work. I've updated the error to help with that:
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we are defaulting to Airflow 3 across the CLI when that is released. I only set the flag in the screenshot because it isn't released yet.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case, if a user does not set the flag in their command, the defaulting logic would pick AF 3, and then this piece of code would error out, which isn't ideal since CLI is picking the default for the users. I think we might have to use AF 2 default for deployment create logic, wdyt?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, agreed that this command should exclude Airflow 3 from the default runtime version, so I've pushed a commit for that.