Use floating tag for init of Airflow 3 Dockerfile by jeremybeard · Pull Request #1847 · astronomer/astro-cli
Conversation
Description
This changes the astro dev init Dockerfile for Airflow 3 to use the minor version floating tag instead of the exact patch tag (e.g. 3.0 instead of 3.0-1). This will mean that new patches of a minor version will automatically be picked up by the project.
📋 Checklist
- Rebased from the main (or release if patching) branch (before testing)
- Ran
make testbefore taking out of draft - Ran
make lintbefore taking out of draft - Added/updated applicable tests
- Tested against Astro-API (if necessary).
- Tested against Houston-API and Astronomer (if necessary).
- Communicated to/tagged owners of respective clients potentially impacted by these changes.
- Updated any related documentation
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped this file because it seems to be interacting with Docker Hub and so can unreliably fail, and is anyway not really unit testing any of the CLI logic.
| err := airflowInit(cmd, args) | ||
| s.NoError(err) | ||
|
|
||
| b, _ := os.ReadFile(filepath.Join(s.tempDir, "Dockerfile")) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More non-unit unit testing, this time these fail because now that Airflow 3 is released the default Dockerfile does not contain this string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 participant