add af3 deployment logs support by jaketf · Pull Request #1878 · astronomer/astro-cli
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments.
| go 1.23.0 | ||
|
|
||
| // toolchain go1.24.1 | ||
| toolchain go1.24.1 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this toolchain entry? Should we just update the go version to 1.24?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question.
I have issues when this line is present when using debugger in IDE.
I have had issues in the past when this line is missing when running make fmt (gofumpt under the hood).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it for now and see if anything breaks in CI
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider it blocking but it would be nice for the values to agree I guess? Anyway, approving as it is commented in main.