Home Original page

Removed create and update deployment and replaced with upsert deployment by rujhan-arora-astronomer · Pull Request #1915 · astronomer/astro-cli

Conversation

@rujhan-arora-astronomer

Description

Removed create and update deployment and replaced with upsert deployment. This is only for Software versions >= 1.0.0.
For older Software versions, CLI would use the existing create and update flows.

🎟 Issue(s)

Related https://github.com/astronomer/issues/issues/7570

🧪 Functional Testing

Locally

📸 Screenshots

Screenshot 2025-08-19 at 12 26 17 PM Screenshot 2025-08-19 at 12 26 28 PM Screenshot 2025-08-19 at 12 38 30 PM Screenshot 2025-08-19 at 12 38 39 PM Screenshot 2025-08-19 at 12 38 52 PM

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@pgvishnuram

for airflow3 software now enforces dagProcessor we should them as well

pgvishnuram

karankhanchandani

// UpdateDeployment - update a deployment
func (h ClientImplementation) UpdateDeployment(variables map[string]interface{}) (*Deployment, error) {
reqQuery := DeploymentUpdateRequest.GreatestLowerBound(version)
if variables["payload"] != nil {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for you to add test for this if statement?

karankhanchandani

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM.