improve the dag server upload url flow by pgvishnuram · Pull Request #1926 · astronomer/astro-cli
Description
Previously dag upload URL's were harded to fetch from the baseDomain, this will no longer work with 1.0 api and with this new change we look for dagserver url directly and if not exists it will reconstruct the url from airflow url in order to handle both old api version and new code changes
🎟 Issue(s)
🧪 Functional Testing
There is no change from the user prespective
astro deploy --dags will auto detect and use the upload url for respective clustered deployments
📸 Screenshots
with above code changes it auto detects the url from deployments without needing to use hardcoded base domain from the config
📋 Checklist
- Rebased from the main (or release if patching) branch (before testing)
- Ran
make testbefore taking out of draft - Ran
make lintbefore taking out of draft - Added/updated applicable tests
- Tested against Astro-API (if necessary).
- Tested against Houston-API and Astronomer (if necessary).
- Communicated to/tagged owners of respective clients potentially impacted by these changes.
- Updated any related documentation