Home Original page

chore: upgrade Go version from 1.23 to 1.24 by rchojn · Pull Request #1937 · astronomer/astro-cli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code compiles successully, however, I see there's another place in the config.yml (integration-test job, line 117, which manually installs golang version 1.23.4):

integration-test:
    description: "Run integration tests"
    steps:
      - checkout
      - run:
          name: Install Go
          command: |
            set -e
            cd /tmp
            curl -Lo go.tar.gz https://go.dev/dl/go1.23.4.linux-amd64.tar.gz
            sudo rm -rf /usr/local/go
            sudo tar -C /usr/local -xvf go.tar.gz
            GOROOT=/usr/local/go go version
            echo 'export GOROOT=/usr/local/go' >> $BASH_ENV

Can you update this place as well please ?