Fix remote deploy push logic around figuring out registry from the endpoint by neel-astro · Pull Request #1966 · astronomer/astro-cli

Description

  • Fix the registry endpoint parse logic for remote registry, as they do not follow the standard for existing Astro registries.

Error that users were facing with AWS ECR:

astro remote deploy
Authenticated to Astro

Building client image for host platform
✔ Project image has been updated
Pushing client image to configured remote registry
Error: failed to push client image: internal logic error: unsure how to get registry from image name <registry endpoint>

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

image

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • Rebased from the main (or release if patching) branch (before testing)
  • Ran make test before taking out of draft
  • Ran make lint before taking out of draft
  • Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation