fix: update CognitoUserPoolPreTokenGenerationEventV2 response model by godcrampy · Pull Request #519 · aws/aws-lambda-java-libs
Conversation
Issue #: #516
Description of changes:
- Fix incorrect response model for
CognitoUserPoolPreTokenGenerationEventV2to match the exprected contract from the docs - Expose the fix as
v3.15.0since it's a breaking change. - Update ci scripts for
samplesto use the events library from current build.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
| 21 | ||
| distribution: corretto | ||
|
|
||
| # Install events module using Java 8 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we verified that we need this change? Does CI still pass when we revert this modification?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it doesn't pass. The above CI runs are examples of experiments I tried to make it work with Java 21 (didn't work). The issue is that the event package has it's compiler set to Java 8, hence this looks like a forced move.
LGTM! Thanks! 🎉, I just left a small comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters