Fix e2e tests failure in action of build and test by tiationg-kho · Pull Request #1094 · aws/aws-node-termination-handler

Conversation

@tiationg-kho

Issue #, if available:

Description of changes:

  • Add custom service client when perform e2e test
  • Make sure AEMM is up before NTH
  • Fix validation in prometheus-metrics-test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Lu-David

What's the reasoning behind moving AEMM before NTH helm upgrades? For other tests we always do NTH and then aemm. Wondering if the other tests should be updated as well

@tiationg-kho

This pattern follows the approach in webhook-http-proxy-test, and webhook-secret-test.

I think we should be good for only updating these 3 tests (emit-events-test, prometheus-metrics-test, and webhook-test).

LikithaVemulapalli

LikithaVemulapalli

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm