Add proxy-get over repl by bookshelfdave · Pull Request #75

Add proxy-get over repl by bookshelfdave · Pull Request #75 · basho/riak_repl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be simplified into one line:

ok = riak_api_pb_service:register(riak_repl_pb_get, 128, 129),

Add tests for the rules too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this header really necessary?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to put it in riak_repl.hrl if that's what you mean, just thought it'd be nice to have it separated out. Or did you mean having a default in a hrl at all?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, why does it need to be in a header at all, considering it is referenced in precisely one module.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point, fixed in dcbe896

+1 to merge this into the 1.2 branch when above concerns are addressed.

They were only used in one place, so no point
in having them in a hrl.