Fix for deprecated getLiveSessionData by jjlawren · Pull Request #178 · bretterer/rivian-python-client

Conversation

@jjlawren

Applying the suggested fixes discussed in bretterer/home-assistant-rivian#254. Tests also updated and passing.

Will require a fix in the HA custom component here by also replacing getLiveSessionData with getLiveSessionHistory.

natekspencer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLiveSessionData and getLiveSessionHistory are not compatible data models. As such, instead of remapping the underlying query for get_live_charging_session, it and the related tests should be renamed and validated appropriately.

@jjlawren

Fair enough. This appeared to restore functionality of the HA integration in my limited testing, but I unfortunately wasn't able to set up a full validation environment yet. Please feel free to close if this is the wrong approach.

2 participants

@jjlawren @natekspencer