Home Original page

sso: update go modules by Jusshersmith · Pull Request #273 · buzzfeed/sso

@Jusshersmith

@Jusshersmith 

diff created by running scripts/test

@mccutchen

Should we also add -mod=readonly to the go build commands in our Dockerfile and Makefile to more explicitly require up-to-date module information?

@Jusshersmith

@Jusshersmith

Yeah, I think that sounds like a sensible idea @mccutchen!

@codecov

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   62.21%   62.21%           
=======================================
  Files          54       54           
  Lines        4200     4200           
=======================================
  Hits         2613     2613           
  Misses       1399     1399           
  Partials      188      188

mccutchen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jusshersmith

@Jusshersmith

Think I'm going to need a fresh review on this @mccutchen! (thanks!)

mccutchen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was referenced

Dec 9, 2019