sso_*: use ProxyFromEnvironment in http Transport by Jusshersmith · Pull Request #307 · buzzfeed/sso
Problem
As described in #305, some HTTP clients used in sso_auth and sso_proxy don't allow for use of HTTP_PROXY environment variables -- meaning traffic can't be passed through a proxy if desired.
Solution
Make use of the http.ProxyFromEnvironment method, which allows for usage of these environment variables.
We already make use of this in one HTTP client within sso_proxy here:
sso/internal/proxy/reverse_proxy.go
Line 53 in 03e1259
| Proxy: http.ProxyFromEnvironment, |