Sync clojure-mode-extra-font-locking.el version with clojure-mode.el by manphiz · Pull Request #679 · clojure-emacs/clojure-mode
- It looks like the version of clojure-mode-extra-font-locking.el has been out-of-sync with clojure-mode.el and has been stuck in 3.0.0 for a long time.
- This patch sync the version with the current snapshot.
Note: it would be great to fix 5.18.x branch but not really needed I guess.
- The commits are consistent with our [contribution guidelines][1].
- You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
- You've run
M-x checkdocand fixed any warnings in the code you've written. - You've updated the changelog (if adding/changing user-visible functionality).
- You've updated the readme (if adding/changing user-visible functionality).
I see. However, it looks like on stable.melpa.org the version of clojure-mode-extra-font-locking is the same as clojure-mode[1]. This may cause an issue that a locally built clojure-mode-extra-font-locking may get superseded by the version on stable.melpa.org, but they are actually the same version. Is there a way to let stable.melpa.org honor the version specified in the source file?
[1] https://stable.melpa.org/#/clojure-mode-extra-font-locking
I don't think so, as MELPA uses the newest tag as the version instead of the version metadata. Probably the only solution would be to move clojure-mode-extra-font-locking to a separate repo. CIDER's dynamic font-locking made this package somewhat obsolete, so I haven't thought much about it recently.
Additional semi-relevant question: did we lose font-locking in the mini-buffer with these changes in version 3.0?
@jackrusher For CIDER's eval commands? I don't recall if we ever had font-locking there.
@bbatsov I must have been hallucinating, but I swear there was syntax highlighting on results in the mini-buffer up until cider 3.0.0 🤔
Digging in the history of CIDER I see this was the case about 10 years ago, but I'm not sure when and why we changed this. Definitely not related to any changes in clojure-mode, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters